[SYCL] Replaces some of the CL_* enums with PI_* enums. #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbegam, please, resolve merge conflict and clang-format check issues. |
rbegam
force-pushed
the
private/rbegam/sycl-rename-new
branch
2 times, most recently
from
a9ef255 to
5a14600
Compare
|
@rbegam, please, resolve merge conflicts. |
Signed-off-by: rbegam <[email protected]>
Signed-off-by: Rehana Begam <[email protected]>
rbegam
force-pushed
the
private/rbegam/sycl-rename-new
branch
from
5a14600 to
107c86d
Compare
|
@bader done. please review. |
Signed-off-by: Rehana Begam <[email protected]>
Signed-off-by: Rehana Begam <[email protected]>
romanovvlad
approved these changes
Mar 12, 2020
|
@romanovvlad all comments have been resolved. please submit as I do not have write permission. thanks. |
fwyzard
reviewed
Mar 13, 2020
| PI_COMMAND_EVENTS_WAIT = CL_COMMAND_MARKER, | ||
| PI_COMMAND_MEMBUFFER_COPY = CL_COMMAND_COPY_BUFFER, | ||
| PI_COMMAND_MEMBUFFER_FILL = CL_COMMAND_FILL_BUFFER | ||
| } _pi_command_type; |
There was a problem hiding this comment.
These changes break the CUDA plugin, e.g.
llvm/sycl/plugins/cuda/pi_cuda.cpp
Line 1634 in dc729a7
There was a problem hiding this comment.
Those are renamed i.e., PI_COMMAND_MEMBUFFER_WRITE -> PI_COMMAND_TYPE_MEM_BUFFER_WRITE
There was a problem hiding this comment.
Yes, but the renaming was not propagated to the CUDA plugin.
There was a problem hiding this comment.
There is no buildbot to check that at the moment, but we are working on adding it.
Meanwhile to check locally you can try this https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md#build-dpc-toolchain-with-support-for-nvidia-cuda
bader
pushed a commit
that referenced
this pull request
Mar 14, 2020
The CUDA backend cannot currently build due to the renaming of descriptors done in #1239. This PR adjusts the backend to the new descriptor names. Signed-off-by: Steffen Larsen <[email protected]>
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Jul 18, 2024
We made a mistake several years ago by introducing `pi_mem_advice` argument into a public interface in intel#1239. This mistake was caught a year later and addressed in intel#4100, but unfortunately instead of removing this incorrect overload, it was deprecated. Even deprectation was done improperly, because this method is *not* deprecated in SYCL 2020 - it *doesn't exists* in SYCL 2020. This PR removes the method completely, even though our messaging was wrong. The assumption is that there are no actual users who went and used undocumented non-public `pi_mem_advice` in their codebases.
AlexeySachkov
added a commit
that referenced
this pull request
Jul 18, 2024
We made a mistake several years ago by introducing `pi_mem_advice` argument into a public interface in #1239. This mistake was caught a year later and addressed in #4100, but unfortunately instead of removing this incorrect overload, it was only deprecated. The deprecation wasn't done quite correctly, because this method is *not* deprecated in SYCL 2020 - it *doesn't exists* in SYCL 2020. This PR removes the method completely, even though our messaging was wrong. The assumption is that there are no actual users who went and used undocumented non-public `pi_mem_advice` in their codebases. This is patch is essentially a by-product of #14145 and it is done to simplify that change, i.e. PI plugins removal should not be ABI-breaking by itself, we just need to cleanup some of our exported symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rbegam [email protected]
Co-Authored-By: Alexey Bader [email protected]